12-02-10 07:18 AM - Post#84948    

I have this upgrade to perform.

I have a modded lightbox Chris Peterson set up for me so that clicked images open full-size rather than resizing to browser.

The change is in showtopic.php

Find

Code:

<script type=\"text/javascript\" src=\"{$conf['full_url']}/includes/lightbox/js/lightbox-rs.js\"></script>

Change to

Code:

<script type=\"text/javascript\" src=\"{$conf['full_url']}/includes/lightbox/js/lightbox.js\"></script>

Rather than finding out the hard way, is the upgrade likely to revert me back to the default lightbox? If so any ideas on what I need to get the full size lightbox back?

12-02-10 07:20 AM - Post#84949    

    In response to sb1963

Oh - & the code boxes have gone small! I noticed they'd resized in my blog here too where I keep notes on upgrades etc

12-02-10 09:35 AM - Post#84955    

    In response to sb1963

in 3.1 Final 2 I moved completely away from scriptaculous/Prototype and on Jquery. The old Lightbox coding and userpage were built around scriptaculous which is not being developed anymore and Jquery has a more robust life cycle. Since that change you will notice that any box you build around that old code will need to be re-developed using the new coding. The portal page has been changed to use JQuery UI. Boxes may appear different on their as well.

The artist formerly known as scroungr Couch-Tomatoe

12-02-10 01:42 PM - Post#84964    

    In response to Couchtomatoe

Code box's or the user page won't really affect me, that was an aside on what I noticed here. it's my lightbox I'm worried about.

12-02-10 03:10 PM - Post#84965    

    In response to sb1963

well as long as your lightbox conforms to the new JQuery Lightbox there shouldn't be an issue but if you try to run the Scriptaculous Lightbox code with the new JQuery one then there will be conflicts.

The artist formerly known as scroungr Couch-Tomatoe

12-02-10 07:51 PM - Post#84968    

    In response to Couchtomatoe

The only difference in my code to the standard showtopic.php is mine is lightbox-rs.js rather than lightbox.js

12-02-10 08:54 PM - Post#84969    

    In response to sb1963

lightbox-rs.js is part of the Scriptaculous Lightbox code that is no longer being supported by FusionBB. any links to such file will need to be changed to JQuery Lightbox which uses lightbox.js .

Scriptaculous and JQuery do not co-exist well together. So if you continue to use the old lightbox-rs.js going forward then FusionBB will not support nor troubleshoot that code.. In fact there is no _scriptaculous nor lightbox directories in the includes directories going forward and all code has moved to jquery

The artist formerly known as scroungr Couch-Tomatoe

12-03-10 08:58 AM - Post#84971    

    In response to Couchtomatoe

It should be supported until 3.3 shouldn't it? Will the change to jquery not be done automatically by the upgrade?

I'm still not clear if my full size lightbox will work on 3.1 Final 2.

The minor code change I have is in showtopic.php which I guess will be overwritten by the upgrade. I do notice lightbox-rs.js is among the text of the new showtopic.php but it's above my head to figure out if I'll be ok or not - hence the question.

I'll try & get a test site set up over the weekend. Full size is critical to both my sites as many of our images are of text pages & the resize to browser can render them unreadable.
It's a big part of why we are with Fusionbb as this feature was introduced after our request & then tweaked fo full-size for us by Chris P.

I think I have asked before but I'll do a feature request for this to be an admin setting choice:

A - lightbox resize to browser
B - lightbox open full size

12-03-10 09:02 AM - Post#84972    

    In response to sb1963

Well actually there is a jquery.lightbox-rs.js not a lightbox-rs.js

The artist formerly known as scroungr Couch-Tomatoe

12-03-10 09:21 AM - Post#84973    

    In response to Couchtomatoe

Aye - I saw the jquery prefix but as I say above my head so I'll wait & see.